Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test module and test on neovim 0.10.0 #156

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

cryptomilk
Copy link
Collaborator

Update test module and test on neovim 0.10.0.

@cryptomilk cryptomilk requested a review from willothy June 6, 2024 06:36
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the 0.7 testing? mini.test seems to have soft-deprecated support for <0.8, and packages for v0.9 or higher are available pretty much everywhere.

Otherwise lgtm! Good idea.

@cryptomilk
Copy link
Collaborator Author

I first remove it, but focus also support 0.7.0 and I didn't want to remove support right now.

Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, sounds good! Things still seem to work fine on 0.7 as well, so if we want to keep supporting older versions then keeping the tests def makes sense.

We can deal with the mini.test deprecation if/when it breaks :)

@willothy willothy merged commit 948b32e into nvim-focus:master Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants